-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Fix for 3 vulnerabilities #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15032660 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420 - https://snyk.io/vuln/SNYK-JS-TAR-15127355
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the project's security posture by resolving multiple medium-severity vulnerabilities within its Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, attempts to fix three security vulnerabilities by changing dependency versions in package.json. However, the proposed changes are incorrect for this monorepo setup. It replaces workspace:* specifiers with very old, hardcoded versions for @storybook/builder-vite and @storybook/svelte. This will break the workspace linking and likely cause the build to fail. The change should be rejected, and the vulnerabilities should be addressed manually, for instance by using Yarn's resolutions to upgrade the vulnerable transitive dependencies.
| "@storybook/builder-vite": "0.1.22", | ||
| "@storybook/svelte": "4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change incorrectly downgrades @storybook/builder-vite and @storybook/svelte to very old, hardcoded versions. In this monorepo, workspace:* is used to ensure packages use the current versions from the workspace (which is 8.3.0-beta.3). Pinning to 0.1.22 and 4.0.0 will break compatibility and cause build failures.
This automated change by Snyk is incorrect. To fix the underlying vulnerabilities, you should use Yarn's resolutions feature in the root package.json to force newer versions of the vulnerable transitive dependencies (like tar and eslint), rather than downgrading these core packages. This PR should be rejected.
"@storybook/builder-vite": "workspace:*",
"@storybook/svelte": "workspace:*"
Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/svelte-vite/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15032660
SNYK-JS-ESLINT-15102420
SNYK-JS-TAR-15127355
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal