Skip to content

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 1, 2026

snyk-top-banner

Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/svelte-vite/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15032660
  693  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  623  
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  596  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Directory Traversal

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the project's security posture by resolving multiple medium-severity vulnerabilities within its yarn dependencies. It primarily involves updating specific Storybook-related packages to their patched versions, aiming to mitigate risks associated with directory traversal and uncontrolled recursion. A key aspect to note is the requirement for manual intervention to update the yarn.lock file and potentially the .yarn/cache for zero-install setups.

Highlights

  • Vulnerability Fixes: This pull request, automatically generated by Snyk, addresses three medium-severity vulnerabilities: two Directory Traversal issues (SNYK-JS-TAR-15032660, SNYK-JS-TAR-15127355) and one Uncontrolled Recursion issue (SNYK-JS-ESLINT-15102420) found in the project's yarn dependencies.
  • Dependency Updates: The package.json file has been updated to bump the versions of @storybook/builder-vite from workspace:* to 0.1.22 and @storybook/svelte from workspace:* to 4.0.0.
  • Yarn Zero-Installs Consideration: For users leveraging Yarn's zero-installs feature, a manual yarn command execution is required to update the .yarn/cache/ directory, as this PR does not modify it directly.
  • Manual yarn.lock Update Required: Snyk reported a failure to automatically update the yarn.lock file, necessitating a manual update of this file before the pull request can be merged.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix three security vulnerabilities by changing dependency versions in package.json. However, the proposed changes are incorrect for this monorepo setup. It replaces workspace:* specifiers with very old, hardcoded versions for @storybook/builder-vite and @storybook/svelte. This will break the workspace linking and likely cause the build to fail. The change should be rejected, and the vulnerabilities should be addressed manually, for instance by using Yarn's resolutions to upgrade the vulnerable transitive dependencies.

Comment on lines +50 to +51
"@storybook/builder-vite": "0.1.22",
"@storybook/svelte": "4.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly downgrades @storybook/builder-vite and @storybook/svelte to very old, hardcoded versions. In this monorepo, workspace:* is used to ensure packages use the current versions from the workspace (which is 8.3.0-beta.3). Pinning to 0.1.22 and 4.0.0 will break compatibility and cause build failures.

This automated change by Snyk is incorrect. To fix the underlying vulnerabilities, you should use Yarn's resolutions feature in the root package.json to force newer versions of the vulnerable transitive dependencies (like tar and eslint), rather than downgrading these core packages. This PR should be rejected.

    "@storybook/builder-vite": "workspace:*",
    "@storybook/svelte": "workspace:*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants