Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/frameworks/preact-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"prep": "jiti ../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@storybook/builder-vite": "workspace:*",
"@storybook/builder-vite": "0.1.22",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces a workspace dependency with a very old, fixed version from the public registry. The workspace:* protocol is essential for monorepo setups, ensuring that local packages are used. By pinning @storybook/builder-vite to 0.1.22, you are introducing a significant version mismatch, as other packages in this monorepo (like @storybook/preact) are on version 8.3.0-beta.3. This will almost certainly lead to build failures or runtime errors due to incompatible APIs. The security vulnerability should be addressed within the @storybook/builder-vite package or by updating the lockfile, not by breaking the workspace link.

Suggested change
"@storybook/builder-vite": "0.1.22",
"@storybook/builder-vite": "workspace:*",

"@storybook/preact": "workspace:*"
},
"devDependencies": {
Expand Down
Loading