-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Fix for 2 vulnerabilities #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by upgrading key Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix two security vulnerabilities by changing dependency versions in package.json. However, the proposed change is incorrect for this monorepo setup. It replaces workspace:* dependencies with pinned, much older versions from the public registry. This is a significant downgrade that will break the internal package linking and likely cause the project to fail to build or run correctly. The change should be rejected, and the underlying vulnerabilities should be addressed by updating the specific transitive dependencies, for instance by using resolutions in the root package.json.
| "@storybook/builder-vite": "0.1.22", | ||
| "@storybook/svelte": "4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change incorrectly replaces workspace:* with pinned, much older versions of @storybook/builder-vite and @storybook/svelte. In this monorepo, workspace:* ensures that the latest code from within the workspace is used (version 8.3.0-beta.3 for both packages, based on other package.json files in the repository). Pinning to 0.1.22 and 4.0.0 respectively is a significant downgrade and will almost certainly break the build or lead to incorrect behavior by pulling old versions from the public registry instead of using the local packages.
While the intent is to fix security vulnerabilities, this approach is incorrect. The vulnerabilities in transitive dependencies should be addressed differently, for example by using Yarn's resolutions field in the root package.json to force a secure version of the vulnerable package (e.g., tar or eslint) across the workspace, without breaking the internal package linking. The warning in the PR description that yarn.lock failed to update is a strong indicator that this change introduces dependency conflicts.
"@storybook/builder-vite": "workspace:*",
"@storybook/svelte": "workspace:*"
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/svelte-vite/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15127355
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal