Skip to content

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 2, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/svelte-vite/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  127  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  45  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Directory Traversal

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by upgrading key yarn dependencies within the svelte-vite framework. Specifically, it updates @storybook/builder-vite and @storybook/svelte to newer versions to remediate two critical vulnerabilities: Directory Traversal and Uncontrolled Recursion.

Highlights

  • Dependency Updates: The @storybook/builder-vite dependency has been updated from workspace:* to version 0.1.22.
  • Dependency Updates: The @storybook/svelte dependency has been updated from workspace:* to version 4.0.0.
  • Vulnerability Fixes: These dependency updates address two identified security vulnerabilities: a Directory Traversal issue (SNYK-JS-TAR-15127355) and an Uncontrolled Recursion issue (SNYK-JS-ESLINT-15102420).
Changelog
  • code/frameworks/svelte-vite/package.json
    • Updated @storybook/builder-vite from workspace:* to 0.1.22.
    • Updated @storybook/svelte from workspace:* to 4.0.0.
Activity
  • Snyk automatically created this pull request to address identified vulnerabilities.
  • The PR includes a warning indicating that the yarn.lock file failed to update and requires manual intervention.
  • Snyk provided detailed information on the vulnerabilities being fixed, including their scores and links to further documentation.
  • Notes for users employing Yarn's zero-installs feature were included, advising on the need to run yarn to update the .yarn/cache directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix two security vulnerabilities by changing dependency versions in package.json. However, the proposed change is incorrect for this monorepo setup. It replaces workspace:* dependencies with pinned, much older versions from the public registry. This is a significant downgrade that will break the internal package linking and likely cause the project to fail to build or run correctly. The change should be rejected, and the underlying vulnerabilities should be addressed by updating the specific transitive dependencies, for instance by using resolutions in the root package.json.

Comment on lines +50 to +51
"@storybook/builder-vite": "0.1.22",
"@storybook/svelte": "4.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces workspace:* with pinned, much older versions of @storybook/builder-vite and @storybook/svelte. In this monorepo, workspace:* ensures that the latest code from within the workspace is used (version 8.3.0-beta.3 for both packages, based on other package.json files in the repository). Pinning to 0.1.22 and 4.0.0 respectively is a significant downgrade and will almost certainly break the build or lead to incorrect behavior by pulling old versions from the public registry instead of using the local packages.

While the intent is to fix security vulnerabilities, this approach is incorrect. The vulnerabilities in transitive dependencies should be addressed differently, for example by using Yarn's resolutions field in the root package.json to force a secure version of the vulnerable package (e.g., tar or eslint) across the workspace, without breaking the internal package linking. The warning in the PR description that yarn.lock failed to update is a strong indicator that this change introduces dependency conflicts.

    "@storybook/builder-vite": "workspace:*",
    "@storybook/svelte": "workspace:*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants