Do not export sampler for device==mps && dtype==bfloat16 #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As titled.
Seeing this error:
```
E 00:00:13.059103 executorch:et_metal.mm:246] ETMetalShaderLibrary: Failed to compile shader library: program_source:3813:29: error: assigning to 'bfloat' from incompatible type 'float'
tmp_acc_2 = tmp0;
^~~~
E 00:00:13.059124 executorch:et_metal.mm:263] ETMetalShaderLibrary: Library not compiled
E 00:00:13.059126 executorch:et_metal.mm:301] ETMetalShaderLibrary::getKernelFunction: Failed to get pipeline state for 'generated_kernel'
E 00:00:13.059127 executorch:shim_mps.mm:105] aoti_torch_mps_get_kernel_function: Failed to get kernel function 'generated_kernel'
E 00:00:13.059129 executorch:shim_mps.mm:517] aoti_torch_mps_run_command_block: null function handle
```
When running metal delegated argmax model. This PR disable the sampler export code path, let runner fallback to C++ CPU sampler.
Gasoonjia
approved these changes
Jan 28, 2026
Contributor
Gasoonjia
left a comment
Gasoonjia
left a comment
There was a problem hiding this comment.
stamp for unblock. plz take care of the broken cis
JacobSzwejbka
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.
Seeing this error:
When running metal delegated argmax model. This PR disable the sampler export code path, let runner fallback to C++ CPU sampler.