Mark CI test_training_vlm_and_liger as xfail#5202
Merged
albertvillanova merged 3 commits intohuggingface:mainfrom Mar 2, 2026
Merged
Mark CI test_training_vlm_and_liger as xfail#5202albertvillanova merged 3 commits intohuggingface:mainfrom
albertvillanova merged 3 commits intohuggingface:mainfrom
Conversation
albertvillanova
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
approved these changes
Mar 2, 2026
albertvillanova
added a commit
that referenced
this pull request
Mar 2, 2026
This reverts commit 0bf875c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark test_training_vlm_and_liger as xfail.
Fix #5201.
This PR upsdates test suite for
GRPOTrainerby adding a conditional xfail marker for a specific model test. This marker helps to handle an upstream issue with the Liger Kernel integration for future transformers versions, ensuring the test suite remains stable when the issue is present.Testing improvements:
xfailmarker to the"trl-internal-testing/tiny-Qwen2_5_VLForConditionalGeneration"test case intests/test_grpo_trainer.py, which conditionally fails the test when using Liger Kernel version >= 0.8.0 andtransformersversion > 5.2.0, referencing the upstream issue.