fix: run real ingestion during token estimation#199
Merged
sumukshashidhar merged 3 commits intomainfrom Dec 30, 2025
Merged
Conversation
- Replace hardcoded 1K token estimate with actual document extraction - Use MarkItDown (without LLM) to extract content from PDFs/docs - Simulate chunking to get accurate chunk counts - Token estimates now based on real tiktoken encoding of actual content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the token estimation logic to use actual document content instead of hardcoded estimates.
Changes
Before
After
Testing
yourbench estimate example/default_example/config.yamlyourbench estimate config.yamlin harry_potter_quizz directory