Fix < php 8.0 #859
Merged
Fix < php 8.0 #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Union return type was only added in 7.4.
Member
Author
|
ping @kovshenin to get the project green |
Contributor
|
Is this necessary? Altis master doesn't support PHP < 8.0 |
Member
Author
Ideally yes, though HM Linter is blocked on humanmade/linter-bot#162 If we dont want to merge this, I'd suggest we move away from HM Linter and run PHPCS in github actions instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Union return type was only added in 8.0. So this fails the hm-linter checks