[SDK] Fix typescript types in return statements #3575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and WorkerUtils to allow null values - Improve error handling in all references
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
dnechay
reviewed
Sep 22, 2025
Collaborator
dnechay
left a comment
dnechay
left a comment
There was a problem hiding this comment.
lgtm overall, some minor comments
Could you please also export error classes from sdk as mentioned in the issue? It would help to simplify some error checks for SDK consumers
...cle/server/src/modules/escrow-completion/results-processing/escrow-results-processor.spec.ts
Outdated
Show resolved
Hide resolved
...ges/apps/reputation-oracle/server/src/modules/escrow-completion/escrow-completion.service.ts
Outdated
Show resolved
Hide resolved
...pps/reputation-oracle/server/src/modules/escrow-completion/escrow-completion.service.spec.ts
Outdated
Show resolved
Hide resolved
...pps/reputation-oracle/server/src/modules/escrow-completion/escrow-completion.service.spec.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/abuse/abuse.service.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/abuse/abuse.service.spec.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/common/guards/signature.auth.ts
Outdated
Show resolved
Hide resolved
packages/apps/fortune/recording-oracle/src/common/guards/signature.auth.ts
Show resolved
Hide resolved
packages/apps/fortune/exchange-oracle/server/src/common/guards/signature.auth.ts
Show resolved
Hide resolved
packages/apps/fortune/exchange-oracle/server/src/modules/webhook/webhook.service.spec.ts
Outdated
Show resolved
Hide resolved
- Remove unused castings for null values - Export error classes in SDK
dnechay
reviewed
Sep 25, 2025
Collaborator
There was a problem hiding this comment.
LGTM codewise
Please add changesets to this PR as per new SDK release flow
I would also recommend to apply next strategy for any SDK-related PR:
- Make necessary changes
- Go through review cycles
- Get an "approval" comment
- Generate changesets and docs once all changes approved
This way you won't have to re-generate docs in review cycle + they won't create noise in "change files" view for PR reviewer, wdyt?
Or maybe even generate docs only in release PR?
packages/apps/reputation-oracle/server/src/common/guards/signature.auth.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/common/guards/signature.auth.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/common/guards/signature.auth.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/common/guards/signature.auth.spec.ts
Outdated
Show resolved
Hide resolved
…ls, EscrowStatus, and various type aliases - Adjust null handling in SignatureAuthGuard - Generated new changeset
Contributor
Author
|
Thanks for the suggestion @dnechay, will apply it. Pushed new changes with changesets |
dnechay
previously approved these changes
Sep 25, 2025
Collaborator
dnechay
left a comment
dnechay
left a comment
There was a problem hiding this comment.
LGTM
One non-blocking suggestion
dnechay
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
#3512
Context behind the change
How has this been tested?
Deployed fortune locally and checked that the whole fortune flow works
Release plan
Deploy new typescript SDK version
Potential risks; What to monitor; Rollback plan
None