[2.x] Update the realtime compiler to only serve source media files#2012
Merged
emmadesilva merged 1 commit intonew-asset-systemfrom Nov 11, 2024
Conversation
bf25ff5 to
2176280
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## new-asset-system #2012 +/- ##
====================================================
Coverage 100.00% 100.00%
Complexity 1891 1891
====================================================
Files 194 194
Lines 5044 5044
====================================================
Hits 5044 5044 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
This PR changes the realtime compiler to only serve assets from the media source directory (
_media), rather than also checking the site output directory (_site/media).Motivation
The realtime compiler is designed to emulate how the site will behave when served from a web server. When building the site, files from
_mediaare copied to_site/media. Having the realtime compiler serve files from both locations could lead to inconsistencies and confusion about which version is being served.While we could use
filemtime()to serve the latest version, this would not accurately represent the production environment where only the files in_site/mediawould be available. Additionally, any file in_site/mediawould be overwritten by the next build anyway.This change:
References
See the documentation about media directories in
managing-assets.md: