[2.x] Replace --run-dev and --run-prod build command flags with --run-vite flag#2013
Merged
emmadesilva merged 5 commits intonew-asset-systemfrom Nov 11, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## new-asset-system #2013 +/- ##
======================================================
- Coverage 100.00% 99.98% -0.02%
- Complexity 1891 1892 +1
======================================================
Files 194 194
Lines 5044 5044
======================================================
- Hits 5044 5043 -1
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
31eb157 to
7e998a2
Compare
74d2278 to
9f3c99f
Compare
--run-dev and --run-prod build command flags with --run-vite--run-dev and --run-prod build command flags with --run-vite flag
Member
Author
Alternate Name Considerations:Before choosing the option name Alternatives:
Motivations for
Motivations Against Other Options:
|
41e57b9 to
25bbab8
Compare
emmadesilva
added a commit
that referenced
this pull request
Nov 11, 2024
[2.x] Replace `--run-dev` and `--run-prod` build command flags with `--run-vite` flag
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Mix build flags with Vite flag
Description
This PR replaces the
--run-devand--run-prodbuild command flags with a single--run-viteflag. This change is needed because we switched from Laravel Mix to Vite in #2010, which has different commands and behaviors:npm run devwith Vite starts a development server (incompatible with our build process)npm run prodno longer exists, replaced bynpm run buildThe new
--run-viteflag will:npm run buildto compile assets with Vite_site/media(see [2.x] No longer copy files to site output from the asset bundler command #2011)Breaking Changes
--run-devflag--run-prodflag--run-viteflagRelated Issues/PRs
Upgrade Guide
Replace any usage of
--run-devor--run-prodwith--run-vite: