[2.x] Refactor HydeFront styles to TailwindCSS#2024
Merged
emmadesilva merged 110 commits intonew-asset-systemfrom Nov 17, 2024
Merged
[2.x] Refactor HydeFront styles to TailwindCSS#2024emmadesilva merged 110 commits intonew-asset-systemfrom
emmadesilva merged 110 commits intonew-asset-systemfrom
Conversation
5a34e99 to
4e2fa27
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## new-asset-system #2024 +/- ##
====================================================
Coverage 100.00% 100.00%
Complexity 1906 1906
====================================================
Files 195 195
Lines 5078 5080 +2
====================================================
+ Hits 5078 5080 +2 ☔ View full report in Codecov by Sentry. |
4e2fa27 to
a1c530f
Compare
a1c530f to
b9578a7
Compare
Member
Author
b9578a7 to
712cf95
Compare
Member
Author
|
There are going to be some tiny visual regressions/changes, so I'm going to tackle all of those later. Want to get the main refactor done first. |
emmadesilva
commented
Nov 16, 2024
emmadesilva
commented
Nov 16, 2024
…ydefront Remove the `hyde.css` file from HydeFront
… precedence" This reverts commit 16fa89c.
…tailwind-components [2.x] Extract HydeFront partials for Tailwind component templates
This was referenced Dec 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
We are updating how HydeFront is handled for v2. Instead of declaring styles directly in HydeFront alongside Tailwind, we will refactor those styles into Tailwind.
HydeFront will serve two main purposes:
app.cssfile bundled with new apps, available through the HydeFront CDN.app.css, which we will preconfigure.For example, users can include our Tailwind styles granularly using just the
app.cssfile from the HydeFront package. This file will be compiled alongside Tailwind. If users prefer customization, they can remove the import and add the specific styles they want.Todo: Test that checks if config files are matching should test the Tailwind config
Related Changes
hyde.cssfile from HydeFront #2037I think changelog in many parts can be summarized as: