Skip to content

fix: Update grid from PointAt #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
serenayl wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: Update grid from PointAt #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Grids/Grid/src/Grid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,12 +300,12 @@ GridAreas gridArea
transform, Grid2dElementMaterial, rep, false, Guid.NewGuid(), gridArea.Name);
grid2dElement.Extents = boundary;
grid2dElement.AdditionalProperties["UGrid"] = new Grid1dInput(
new Polyline(origin, grid.U.Curve.PointAt(1)),
new Polyline(origin, grid.U.Curve.End),
uPoints,
uOverride?.SubdivisionMode ?? Grid1dInputSubdivisionMode.Manual,
uOverride?.SubdivisionSettings);
grid2dElement.AdditionalProperties["VGrid"] = new Grid1dInput(
new Polyline(origin, grid.V.Curve.PointAt(1)),
new Polyline(origin, grid.V.Curve.End),
vPoints,
vOverride?.SubdivisionMode ?? Grid1dInputSubdivisionMode.Manual,
vOverride?.SubdivisionSettings);
Expand Down Expand Up @@ -376,16 +376,16 @@ private static string GetName(string namingPattern, int idx)
private static string ConvertToANamingPattern(int idx)
{
// Let Q = 26 - number of uppercase characters, N - number of letters in string.
// There are Q^N strings of length N. The first string of length N+1 will have
// There are Q^N strings of length N. The first string of length N+1 will have
// idx = Q^1 + Q^2 + ... + Q^n, which is equal to Q * (Q^N - 1) / (Q - 1).
const int Q = 26;
const int Q = 26;
int N = (int)Math.Ceiling(Math.Log((Q - 1) * (idx + 1) + Q, Q) - 1);
char[] chars = new char[N];

// The goal is to represent idx in string S as a set of characters Ki, where 0 <= Ki < Q.
// Such polynomial is unique for each idx.
// S = K0 + K1 * Q + K2 * Q^2 + ... + K_n-1_ * Q^(N - 1).
//
// S = K0 + K1 * Q + K2 * Q^2 + ... + K_n-1_ * Q^(N - 1).
//
// Each letter Ki are calculated in reverse order as reminder of dividing S by Q.
// Then the letter is removed by dividing and thus dropping the reminder.
for (int i = N - 1; i >= 0; i--)
Expand Down Expand Up @@ -457,7 +457,7 @@ private static List<GridLine> CreateGridLines(GridInputs input,
GridlineNamesIdentityAxis axis,
double radius)
{
var baseLine = new Line(opposingGrid1d.Curve.PointAt(0), opposingGrid1d.Curve.PointAt(1));
var baseLine = new Line(opposingGrid1d.Curve.Start, opposingGrid1d.Curve.End);

var startExtend = origin - baseLine.Start;
var endExtend = origin - baseLine.End;
Expand Down Expand Up @@ -584,7 +584,7 @@ private static (U u, U v) GetStandardizedRecords(GridOutputs output, GridAreas g
private static U GetStandardizedRecords(U u, Grid1dInput uOverride)
{
var gridlines = new List<GridLines>();
var start = uOverride.Curve.PointAt(0);
var start = uOverride.Curve.Start;
var splitPoints = uOverride.SplitPoints
.Select(p => p.DistanceTo(start))
.OrderBy(d => d)
Expand Down