Open
Conversation
cdriesler
suggested changes
Jan 19, 2022
Contributor
cdriesler
left a comment
cdriesler
left a comment
There was a problem hiding this comment.
- Facade Grid
The Grid Defaults override appears to have trouble starting in some cases:
When clicked, nothing happens, console outputs o is undefined and this.contextFunctionInstance is null multiple times.
- Generic Facade
does not play nice with the existing Facade Grid function, tripped myself on this.
Appears to have a similar issue with the override. Maybe I'm configured wrong? On click, nothing happens, console outputs e is undefined
Workflow: https://dev.hypar.io/workflows/a82fd57c-dba5-4a24-b6e1-3e6734980b9e
Reviewed 144 of 144 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @andrewheumann)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some experimental Facade-related functions to building blocks, namely:
Facade Grid (a new version intended to supersede older facade grid functions)
Generic Facade
and two simple template/examples demonstrating how to add new facade styles:
Facade Strategy 1 (utilizing only inputs)
Facade Strategy 2 (utilizing cross-function overrides to inject multiple facade configurations)
The function has been deployed to dev.
[N/A] The function has been tested against the tour. If the function is not used in the tour, mark this as not applicable (NA).
This change is