Port CI workflow and lint-order test from develop#84
Closed
heusalagroupbot wants to merge 1 commit intomainfrom
Closed
Port CI workflow and lint-order test from develop#84heusalagroupbot wants to merge 1 commit intomainfrom
heusalagroupbot wants to merge 1 commit intomainfrom
Conversation
Adds .github/workflows/ci.yml and internal/ci/ci_workflow_test.go to ensure lint ordering and CI parity with develop, detected via content-based comparison. Refs: https://github.com/hyperifyio/goagent/issues/??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlandinternal/ci/ci_workflow_test.gofrom the develop mirror to main.work/develop.Details
.github/workflows/ci.ymlandinternal/ci— none existed.make lintrunscheck-go-versionprior togolangci-lint, with an explicit assertion step.internal/ci/ci_workflow_test.gothat validates the Makefile lint recipe ordering and presence of the CI steps.go test ./...successfully post-change.Notes
./work/developwithout modifying branch pointers. It aligns with main’s current Makefile (which already includescheck-go-versionand lint targets).Closes: (link the canonical issue)