feat: add VDR capabilities to the cloud-agent using the prism-node#1685
Draft
yshyn-iohk wants to merge 20 commits intomainfrom
Draft
feat: add VDR capabilities to the cloud-agent using the prism-node#1685yshyn-iohk wants to merge 20 commits intomainfrom
yshyn-iohk wants to merge 20 commits intomainfrom
Conversation
yshyn-iohk
changed the title
|
Contributor
Integration Test Results 23 files - 1 23 suites - 1 3s ⏱️ ±0s Results for commit 4a09ee6. ± Comparison against base commit ed66a9f. This pull request removes 4 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
mineme0110
reviewed
Dec 10, 2025
.github/workflows/build.yml
Outdated
Comment on lines
14
to
16
| contents: write | ||
| packages: write | ||
| id-token: write |
Contributor
There was a problem hiding this comment.
move this permissions to job level then global
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
- Fix PrismNodeDIDService to use OperationMaybe from node_api. - Update integration tests to use the latest snapshot client and GHCR prism-node image. - Add Gherkin scenario and step to create a PRISM DID with an internal vdr key. - Document internalKeys.purpose = vdr in DID creation guide. - switch PRISM_NODE_VERSION to `edge` Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
yshyn-iohk
force-pushed
the
feat/vdr-key
branch
from
dab7ede to
677ca02
Compare
- Require wallet auth on VDR write endpoints; reads remain public. - Add optional didKeyId query param to VDR CRUD and thread wallet context through controller/service. - Update server endpoints/auth wiring and VDR config validation to enforce single driver selection. Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
…r, and REST API with multi-tenancy - Added prism-node driver config defaults (incl. prismNodeDriverEnabled) and wired VdrService to consume the shared prism-node blocking stub instead of opening its own channel. - Introduced VdrOperationSigner/PrismNodeVdrOperationSigner to resolve the wallet’s VDR key (multi-tenant), build signed Atala operations, and return MissingVdrKey when absent. - Updated AppConfig validation/tests and application.conf with the new prism-node config fields; ensured single-driver validation still applies. Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Mitigate [S8264](https://sonarcloud.io/organizations/hyperledger-identus/rules?open=githubactions%3AS8264&rule_key=githubactions%3AS8264) Sonarcloud security alert Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Mitigate [S7637](https://sonarcloud.io/organizations/hyperledger-identus/rules?open=githubactions%3AS7637&rule_key=githubactions%3AS7637) Sonarcloud security alert Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
…yml workflow Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
…key removal and cover with tests Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summarize the changes you're submitting in a few sentences, including Jira ticket ATL-xxxx if applicable.
Link to any discussion, related issues and bug reports to give the context to help the reviewer understand the PR.
Alternatives Considered (optional)
Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.
Checklist