Skip to content

check throttling endpoint coverage against scan.yaml#4001

Merged
stephencompall-DA merged 22 commits intomainfrom
s11/cni-3697-full-scan-throttle-coverage
Mar 4, 2026
Merged

check throttling endpoint coverage against scan.yaml#4001
stephencompall-DA merged 22 commits intomainfrom
s11/cni-3697-full-scan-throttle-coverage

Conversation

@stephencompall-DA
Copy link
Contributor

@stephencompall-DA stephencompall-DA commented Feb 17, 2026

If you've missed endpoint coverage you'll get an error in GHA deployment_test, e.g.

Error: Rate limit configuration errors:
- Missing rate limit prefixes for scan.yaml endpoints: /api/scan/readyz
    at validateEffectiveRateLimits (/Users/stephencompall/ide/splice/cluster/pulumi/common/src/ratelimit/envoyRateLimiter.ts:127:11)
️✂️✂️✂️<snip>✂️✂️✂️
make: *** [/Users/stephencompall/ide/splice/cluster/pulumi/pulumi-test-clusters.mk:6: cluster/pulumi/canton-network/test.json] Error 1

You can also see this in canton-network preview; here is a misspelling of endpoint prefix, for example:

error: Error: Rate limit configuration errors:
- Missing rate limit prefixes for scan.yaml endpoints: /api/scan/readyz
- Orphaned rate limit prefixes not matching any scan.yaml endpoint: /api/scan/redyz

From this configuration, the pulumi diff to expect is from canton-network, one per sv, like so:

    ~ splice:RateLimit: (update)
        [urn=urn:pulumi:canton-network.scratchd::canton-network::splice:RateLimit::splice-sv-da-1-scan-app-rate-limit]
        appLabel    : "scan-app"
        globalLimits: {
            fillInterval : "60s"
            maxTokens    : 2147483647
            tokensPerFill: 2147483647
        }
        inboundPort : 5012
        namespace   : "sv-da-1"
      ~ rateLimits  : [
️✂️✂️✂️<a bunch of new appended items>✂️✂️✂️

It does not imply the creation of new EnvoyFilters, which are the actual filters.

Fixes DACH-NY/canton-network-internal#3697.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
@stephencompall-DA stephencompall-DA self-assigned this Feb 17, 2026
…p ci]

Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
@stephencompall-DA stephencompall-DA marked this pull request as ready for review March 2, 2026 21:16
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
@stephencompall-DA stephencompall-DA enabled auto-merge (squash) March 3, 2026 23:56
@stephencompall-DA stephencompall-DA merged commit 67c3c41 into main Mar 4, 2026
67 checks passed
@stephencompall-DA stephencompall-DA deleted the s11/cni-3697-full-scan-throttle-coverage branch March 4, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants