Support transfer instruction expiry#4092
Open
moritzkiefer-da wants to merge 29 commits intococreature/transfer-24hfrom
Open
Support transfer instruction expiry#4092moritzkiefer-da wants to merge 29 commits intococreature/transfer-24hfrom
moritzkiefer-da wants to merge 29 commits intococreature/transfer-24hfrom
Conversation
Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
|
|
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
pasindutennage-da
requested review from
martinflorian-da and
pasindutennage-da
and removed request for
pasindutennage-da
moritzkiefer-da
commented
Feb 26, 2026
Contributor
Author
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
Good work, thanks a lot! Almost there close but a few more edge cases and some testing that are missing.
daml/splice-dso-governance-test/daml/Splice/Scripts/TestDecentralizedAutomation.daml
Outdated
Show resolved
Hide resolved
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
…uction-expiry [ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
moritzkiefer-da
changed the title
moritzkiefer-da
commented
Feb 27, 2026
Contributor
Author
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
Great work! Almost there
daml/splice-dso-governance-test/daml/Splice/Scripts/TestDecentralizedAutomation.daml
Outdated
Show resolved
Hide resolved
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
moritzkiefer-da
commented
Feb 27, 2026
Contributor
Author
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
Nice! only small nits left
daml/splice-dso-governance-test/daml/Splice/Scripts/TestDecentralizedAutomation.daml
Outdated
Show resolved
Hide resolved
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
moritzkiefer-da
commented
Mar 2, 2026
Contributor
Author
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
Nice thanks, one last comment left. I can't approve since I created the PR but feel free to approve yourself. I wouldn't merge it in the base branch for now but instead wait for that to be merged into main (this week or maybe more likely next week hopefully) and then we can rebase on top of main and merge it.
[ci] Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
pasindutennage-da
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves DAML part of #3381