Support traffic purchases after LSU#4143
Merged
moritzkiefer-da merged 2 commits intocanton-3.5from Mar 3, 2026
Merged
Conversation
moritzkiefer-da
force-pushed
the
cocreature/lsu-traffic-purchase
branch
7 times, most recently
from
6d987ce to
ec29489
Compare
[ci] Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
moritzkiefer-da
force-pushed
the
cocreature/lsu-traffic-purchase
branch
from
ec29489 to
ac31477
Compare
moritzkiefer-da
commented
Mar 3, 2026
| .map(_.filter { announcement => | ||
| announcement.mapping.upgradeTime | ||
| .isAfter(now) && announcement.mapping.successorSynchronizerId != synchronizerId | ||
| now.isAfter( |
moritzkiefer-da
commented
Mar 3, 2026
| lazy val scheduledLsu = ScheduledLsuConfig( | ||
| Instant.now().plusSeconds(150).truncatedTo(ChronoUnit.SECONDS), | ||
| Instant.now().plusSeconds(210).truncatedTo(ChronoUnit.SECONDS), | ||
| Instant.now().plusSeconds(250).truncatedTo(ChronoUnit.SECONDS), |
Contributor
Author
There was a problem hiding this comment.
these numbers are more or less random but I kept getting issues (on CI) where a validator tried to startup when the upgrade time was already reached. I don't think I made anything slower there given that my code only kicks in after the upgrade time
Contributor
Author
There was a problem hiding this comment.
with the Daml change this should hopefully become quite a bit simpler as we can ensure that now is after all the apps have started already.
nicu-da
approved these changes
Mar 3, 2026
| } else { | ||
| successorActiveCache.get(()).map { active => | ||
| if (active) { | ||
| successorActiveRef.set(active) |
Contributor
There was a problem hiding this comment.
nit: would be nice to have a log once this is set to true for the first time
Contributor
Author
There was a problem hiding this comment.
good idea, added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[static]
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines