Skip to content

[AST-494] default enable request-id distributed logging interceptor for all grpc services #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamajais merged 1 commit into from
Dec 20, 2025
Merged

[AST-494] default enable request-id distributed logging interceptor for all grpc services #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions grpc-server-utils/src/main/java/org/hypertrace/core/grpcutils/server/InterceptorUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,16 @@ public class InterceptorUtil {
*/
public static ServerServiceDefinition wrapInterceptors(BindableService bindableService) {
return ServerInterceptors.intercept(
bindableService, new RequestContextServerInterceptor(), new ThrowableResponseInterceptor());
bindableService,
new RequestContextLoggingServerInterceptor(),
Copy link

@avinashkolluru avinashkolluru Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this log the entire request context which i believe has the jwt too?

Copy link
Contributor Author

@iamajais iamajais Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wont log yet. We are just putting key value pairs in MDC context here. logging params will be controlled by log-config.yaml file of individual grpc service. like for scan-manager service we are just logging request-id key

new ThrowableResponseInterceptor());
}

public static ServerServiceDefinition wrapInterceptors(
ServerServiceDefinition serviceDefinition) {
return ServerInterceptors.intercept(
serviceDefinition,
new RequestContextServerInterceptor(),
new RequestContextLoggingServerInterceptor(),
new ThrowableResponseInterceptor());
}
}
Loading