Skip to content

201 rate limit the subscribe endpoint #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Nolab0 wants to merge 40 commits into
base: main
Choose a base branch
from
Open

201 rate limit the subscribe endpoint #348

Nolab0 wants to merge 40 commits into from

Conversation

@Nolab0
Copy link
Member

@Nolab0 Nolab0 commented Nov 20, 2025 •
edited by supun-io
Loading

close #201

Important: we must update the webhook URL in hyvor Relay in Production

@Nolab0 Nolab0 requested review from Nadil-K and supun-io November 20, 2025 10:35
@supun-io supun-io force-pushed the 201-rate-limit-the-subscribe-endpoint branch from 3c69466 to 25a3932 Compare November 20, 2025 14:18
supun-io
supun-io reviewed Nov 20, 2025
View reviewed changes
Copy link
Member

@supun-io supun-io left a comment •
edited by Nolab0
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add public API rate limit per IP (30 per minute per IP)
  • move RelayWebhook out of public API: /api/machine
    • add this to routes
    • Move RelayWebhookController
    • RelayWebhookTest
  • check Public API rate limits in a separate test

Nolab0 and others added 24 commits November 21, 2025 11:55
@Nolab0
Add abstraction
5bd9368
@Nolab0
Fix tests
7eff330
@Nolab0
move up the rate limit
c2fc110
@Nolab0
Move wehbook relay to machine API
fe95aa7
@Nolab0
Add machine api rate limit test
d515bb1
@Nolab0
Clean rate limiting class and add clear limiting logic
551cca5
@supun-io @Nolab0
fixes #314 (#349)
3f9e50d
@Nadil-K @Nolab0
Adds brand url to sending profiles (#345)
213fa1b 
* add brand-url backend updates - wip #339

* add brand-url frontend updates - fixes #339

* brand-url at template variables

* php test fixes

* prettier fix
@Nadil-K @Nolab0
fixes #296 (#347)
de485e2
@Nadil-K @Nolab0
Improvements on issue sending (#351)
8f47872 
* fixes #340

* updates hyvor/internal
@Nadil-K @Nolab0
Optimizes list subscriber count fetch (#346)
1920c2b 
* list subscriber count fetch optimization

* php test fixes

* return counts with all keys
@Nolab0
Move wehbook relay to machine API
9199f4d
@Nadil-K @Nolab0
fixes #296 (#347)
c1f5db1
@Nadil-K
Merge remote-tracking branch 'origin/main' into 201-rate-limit-the-su…
2123f81 
…bscribe-endpoint
@Nolab0
Fix ci
63cbc60
@IshiniAvindya @supun-io @Nolab0
Create product banner (#356)
e39c994 
* Create product banner

* rename banner

---------

Co-authored-by: Supun Wimalasena <supun@hyvor.com>
@IshiniAvindya @supun-io @Nolab0
img moved to static (#350)
63c8eef 
* img moved to static

* orgnization

* prettier

* wip

---------

Co-authored-by: Supun Wimalasena <supun@hyvor.com>
@Nadil-K @Nolab0
Console API docs (#359)
0995dd4 
* wip

* complets console api docs - fixes #344

* prettier
@Nadil-K @Nolab0
Final fixes before release (#360)
9416006 
* fixes #353

* fixes #355

* fixes #358

* prettier
@IshiniAvindya @Nolab0
hds version updated (#367)
92b548c 
* hds version updated

hds version updated

* updated package-lock.json
@Nadil-K @Nolab0
Fixes CORS for embed form (#368)
aeacd54 
* form-cors-fix

* fix
@Nadil-K @Nolab0
Health check endpoint (#369)
9cfa1e1 
* /health

* /health test
@Nadil-K @Nolab0
Approval type of content required (#371)
c0a7bfd 
* frontend

* backend

* test

* prettier
@IshiniAvindya @Nolab0
Homepage fixes (#370)
cd2a7e1 
* wip mobile home

* mobile fixes #363

* changes after review

* removed commented styles

* review fixes

* archive site

* updated archivesite.svelte

* Update ArchiveSite.svelte

* Update ArchiveSite.svelte
Nadil-K and others added 14 commits December 29, 2025 18:47
@Nadil-K @Nolab0
fix-branding-for-newsletter-name (#377)
b48ed8c
@Nadil-K @Nolab0
hide lists when one list is avaliable
adececb
@Nadil-K @Nolab0
<=
7f36832
@Nadil-K @Nolab0
Adds a TextInput for brand-url of sending profile (#384)
4c425fc 
* text-input-for-brand-url

* prettier
@Nadil-K @Nolab0
Refactor remaining occurrences of segment to list (#385)
d733e1f 
* SubscriberEdit model fix

* AddSubscribers model fix

* refactor all occurrences

* prettier

* prettier
@Nadil-K @Nolab0
Fixes console newsletter redirect after invite acceptance (#386)
de794f8 
* redirect-fix-after-invite-accept

* test fix
@sakithb @Nolab0
properly unmount when element is disconnected from dom and move style…
2a2f86b 
…sheet creation to constructor (#391)
@sakithb @Nolab0
disable Symfony Entity Resolved (#395)
fac394e
@sakithb @Nolab0
decrease list indentation (#394)
3db54fc 
* decrease list indentation

* update test

* update test
@Nolab0
Move wehbook relay to machine API
eb9a2fa
@Nadil-K @Nolab0
Adds brand url to sending profiles (#345)
6b8f8e9 
* add brand-url backend updates - wip #339

* add brand-url frontend updates - fixes #339

* brand-url at template variables

* php test fixes

* prettier fix
@Nadil-K @Nolab0
Improvements on issue sending (#351)
972fd39 
* fixes #340

* updates hyvor/internal
@Nolab0
Merge branch 'main' into 201-rate-limit-the-subscribe-endpoint
8511e2b
@Nolab0
Fix ci
5ff57ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@supun-io supun-io supun-io left review comments

@Nadil-K Nadil-K Awaiting requested review from Nadil-K

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rate limit the /subscribe endpoint

6 participants

@Nolab0 @supun-io @Nadil-K @IshiniAvindya @sakithb