Skip to content

Conversation

@sakithb
Copy link
Collaborator

@sakithb sakithb commented Dec 17, 2025

@sakithb
Copy link
Collaborator Author

sakithb commented Dec 17, 2025

The colors attribute does not work when set in the markup and only takes effect when it is changed programmatically. This pr let's the user set the attribute in the markup and set the palette.

@sakithb sakithb force-pushed the fix-form-dark-mode-not-applied branch from 3ac3556 to 281d7b6 Compare December 17, 2025 06:20
@sakithb
Copy link
Collaborator Author

sakithb commented Dec 17, 2025

Update docs:
image

@sakithb sakithb linked an issue Dec 19, 2025 that may be closed by this pull request
@sakithb sakithb requested a review from supun-io December 19, 2025 08:01
style.textContent = formCss;
this.shadowRoot!.appendChild(style);

window.addEventListener(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nadil-K what do you think?

On the one hand, I think we should not integrate external systems directly within the embed.

On the other hand, Hyvor Blogs is our own platform. It generally makes sense to have something like this in HP.

Initially, my thought was to handle this at the installation time, by giving the user a code snippet with a code like this included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark mode text color not applied to the form description

3 participants