Creating a collection #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sakithb
commented
Aug 30, 2025
sakithb
commented
- ui
- add bottom margin
- endpoint + tests
- fix failing test
- wip
supun-io
requested changes
Sep 5, 2025
# Conflicts: # backend/composer.json # backend/composer.lock # backend/src/Api/App/Controller/CollectionController.php # backend/src/Api/App/Controller/PublicationController.php # backend/src/Repository/CollectionUserRepository.php
Nadil-K
requested changes
Sep 25, 2025
| throw new AccessDeniedHttpException('Authentication required'); | ||
| } | ||
|
|
||
| $data = json_decode($request->getContent() ?: 'null', true); |
Member
There was a problem hiding this comment.
- Populate a typed input object with
#[MapRequestPayload]. - Do the validations within that object class.
|
|
||
| return $this->json([ | ||
| 'publication' => new \App\Api\App\Object\PublicationObject($publication), | ||
| 'created' => $created, |
Member
There was a problem hiding this comment.
Why do we need these created and attached booleans? Within the current codebase, I don't see any instance of it being used. Shall we remove it @supun-io?
| $attached = false; | ||
|
|
||
| if (!$publication) { | ||
| $publication = $this->publicationService->createPublication($collection, $url, $title ?: null); |
Member
There was a problem hiding this comment.
- Add an optional parameter
flush = trueforcreatePublicationand within the function, only flush the EntityManager if it'strue. - In this case, set that bool to
falsesince we flush it again below. - Do the same for
attachToCollectionIfMissing.
| {/snippet} | ||
| </Modal> | ||
|
|
||
| <slot /> |
Member
There was a problem hiding this comment.
<slot />is deprecated in Svelte 5. Use{@render children()}instead.
| {/snippet} | ||
| </Modal> | ||
|
|
||
| <Modal |
| </div> | ||
| </Modal> | ||
|
|
||
| <Modal bind:show={showAddPublicationModal} size="small" title="Add Publication" closeOnOutsideClick={true} closeOnEscape={true}> |
| {collection.name} | ||
| </ActionListItem> | ||
| {/each} | ||
| <ActionListItem on:select={() => { showCreateCollectionModal = true; showCollections = false; }}> |
Nadil-K
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.