Pass onSubmit callback to CreateFirstCharacter event #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds
onSubmitas an arg to theqb-clothes:client:CreateFirstCharacterand passes it toInitializeCharacter.Details
While default qb scripts dont pass any args, some custom scripts utilize this same event and pass through an onSubmit callback function to trigger once the character is created.
In InitializeCharacter it first checks that the
onSubmitfunction is defined before trying to be used. Therefore this change is still safe for scripts that won't be passing any value in foronSubmit.