fix: show StratoSort Core in macOS dock and Activity Monitor#12
Closed
fix: show StratoSort Core in macOS dock and Activity Monitor#12
Conversation
Fixes #11 macOS shows Electron in the dock and Activity Monitor because it reads the app name from the Electron binary Info.plist during development. - Add productName to package.json so Electron resolves app.name correctly - Set app.name explicitly before any windows/menus are created - Set dock icon programmatically via app.dock.setIcon on macOS - Add postinstall script that patches Electron.app Info.plist on macOS to replace CFBundleName/CFBundleDisplayName with StratoSort Core Production builds were already correct (electron-builder.json has the right productName); this fix targets the development experience.
Owner
Author
|
Superseded by #13 which includes this fix plus additional macOS and RAG improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11 — macOS dock and Activity Monitor show "Electron" instead of "StratoSort Core".
package.json: AddedproductName: "StratoSort Core"so Electron'sapp.nameresolves correctly at runtimesrc/main/simple-main.js: Setapp.nameexplicitly before any windows/menus are created; set dock icon viaapp.dock.setIcon()on macOSscripts/patch-electron-mac.js: New script that patchesElectron.app/Contents/Info.plistto replaceCFBundleName/CFBundleDisplayNamefrom "Electron" to "StratoSort Core"scripts/postinstall.js: Calls the patch script automatically on macOS afternpm installProduction/packaged builds were already correct (
electron-builder.jsonhas the rightproductName). This fix targets the development experience on macOS.How to test (macOS)
npm install(this triggers the Info.plist patch automatically)npm run dev