Merged
Conversation
…s for vector retrieval - Improved the fallback mechanism in OramaVectorService to utilize in-memory sidecar vectors for faster retrieval, with a more robust scoring system. - Introduced a new method, getFileVectorDiagnostics, to diagnose eligibility for primary vector search and provide insights into vector retrieval issues. - Added logging for zero vector results in SearchService to capture diagnostics and prevent silent failures. - Updated default settings to enable auto-generating chunk embeddings during file analysis for improved retrieval depth.
Fixes #10, Fixes #11 - Add productName to package.json and set app.name early in main process - Set macOS dock icon programmatically via app.dock.setIcon - Add postinstall script to patch Electron.app Info.plist on macOS - Add left margin on macOS nav bar to avoid traffic light button overlap - Refine phase navigation tab styling with platform-aware CSS
- Add productName and set app.name early; set dock icon via app.dock.setIcon - Patch Electron Info.plist on macOS via postinstall - Add left margin on nav bar to avoid traffic light button overlap - Refine phase navigation tab styling with platform-aware CSS
- Add productName and set app.name early; set dock icon via app.dock.setIcon - Patch Electron Info.plist on macOS via postinstall - Add left margin on nav bar to avoid traffic light button overlap - Refine phase navigation tab styling with platform-aware CSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements focused on user experience and diagnostics, particularly for macOS users and the application's vector search capabilities. The most significant changes include enhanced macOS branding (dock label, icon, and app name), improved fallback logic and diagnostics for vector search, and user interface refinements for navigation.
macOS Branding and UX Enhancements:
package.json, assigningapp.nameearly in Electron, and patching the Electron.app'sInfo.plistduring development to ensure the correct name and bundle identifier are shown. A new script (scripts/patch-electron-mac.js) is added and invoked during postinstall. The macOS dock icon is also set programmatically to the StratoSort logo in development mode. [1] [2] [3] [4] [5]Vector Search Fallbacks and Diagnostics:
OramaVectorServicefor file-level vector search: now prioritizes in-memory sidecar vectors for fast retrieval and only fetches metadata for top candidates, with a robust fallback to slower methods when needed. [1] [2] [3]getFileVectorDiagnosticsmethod to provide detailed diagnostics when vector search returns no results, including eligibility breakdowns and sample ineligible documents.SearchServiceto log detailed diagnostics (throttled to avoid noise) whenever a vector search yields zero results, aiding debugging and user support. [1] [2] [3]User Interface and Navigation Improvements:
Integration and Dependency Updates:
llamaServiceis resolved (if available) in the main service integration, supporting future extensibility.