reordering of keys for course.format()#1
Open
zubaidit wants to merge 1 commit intoiMishaDev:masterfrom
Open
Conversation
zubaidit
commented
Jul 4, 2021
zubaidit
commented
- when unittesting, comparing json output with actual object data has two issues.
- First one is json display ordering is different from the ordering in format().
- Second one is the date formating is also different.
- This will cause the tests will fail.
- This commit makes everyhing proper.. hopefully :).
- when unittesting, comparing json output with actual object data has two issues. - First one is json display ordering is different from the ordering in format(). - Second one is the date formating is also different. - This will cause the tests will fail. - This commit makes everyhing proper.. hopefully :).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.