RFC056: Update OpenAPI spec for RFC056 (DOC-73) #19
Conversation
gerardishare
changed the title
ishare_openapi_spec.yaml
Outdated
| Optional id of the Service (Capability) of the Service Provider for which | ||
| this AR is selected by the Entitled Party. | ||
| type: string | ||
| example: /service1 |
There was a problem hiding this comment.
this should be an identifier and. not necessarily an endpoint. To make it more clear, you could refer to the attribute in the capabilities endpoint
There was a problem hiding this comment.
Improved in newer version.
| the Entitled Party. | ||
| type: string | ||
| example: did:ishare:EU.NL.NTRNL-12345678 | ||
| serviceIdentifier: |
There was a problem hiding this comment.
service id was not agreed in parties endpoint, that will lead to lots of entries
There was a problem hiding this comment.
I think it is. See https://gitlab.com/ishare-foundation/cab/rfc/-/blob/f003a57e55516272998bc42353a61e29d23927c0/RFC%20Documents/RFC056/README.md option 1 "If the Entitled Party has registered a capabilities endpoint in which an AR is registered that must be used for a specific capability, then that AR must be used.".
There was a problem hiding this comment.
but that is not correct, it was never agreed, it was only discussed, but the implications are too big. I cannot approve it.
There was a problem hiding this comment.
combined solutions chosen in not very well explained. capability reference needs to be standardised and it must still be looked up in capabilities endpoint for the URL and other details. and don't forget the overhead and potential for errors.
No description provided.