Allow dest to refer to a filename relative to working directory#64
Open
slycordinator wants to merge 2 commits intoiTaybb:masterfrom
Open
Allow dest to refer to a filename relative to working directory#64slycordinator wants to merge 2 commits intoiTaybb:masterfrom
slycordinator wants to merge 2 commits intoiTaybb:masterfrom
Conversation
1) Allows user to set dest as merely a filename to be placed in the current directory If self.dest is set, but lacks a directory portion, then sets self.dest to itself with the working directory ['.'+os.sep] appended to the front of it. 2) Made so only checks for / creates the output directory once.
When destination has no directory component, add logging info for placing the file into the working directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If self.dest is set, but lacks a directory portion, then sets self.dest to itself with the working directory ['.'+os.sep] appended to the front of it.
Note:
Without the change, if the the dest was a simply specified as a filename, the calls to
os.makedirs(os.path.dirname(self.dest))failed, becauseos.path.dirname(self.dest)evaluated to ''