Remove all deprecated references from iTwin.js 5.x in changed-elements-react #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b6e2fdf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CalebGerman
commented
Sep 12, 2025
packages/test-app-frontend/src/App/ITwinJsApp/AppUi/PropertyComparisonFrontstage.tsx
Outdated
Show resolved
Hide resolved
CalebGerman
commented
Sep 12, 2025
packages/test-app-frontend/src/App/ITwinJsApp/AppUi/PropertyComparisonViewport.tsx
Show resolved
Hide resolved
CalebGerman
commented
Sep 12, 2025
packages/test-app-frontend/src/App/ITwinJsApp/AppUi/VersionCompareFrontstageManager.ts
Outdated
Show resolved
Hide resolved
CalebGerman
commented
Sep 15, 2025
diegopinate
reviewed
Sep 15, 2025
packages/changed-elements-react/src/api/SideBySideVisualizationManager.ts
Outdated
Show resolved
Hide resolved
diegopinate
reviewed
Sep 15, 2025
Collaborator
There was a problem hiding this comment.
Toggling off side by side toggle in property comparison seems to be broken, e.g. the view is reset, and the slider doesn't do anything:
Then if you press the toggle again, the visualization is lost for side-by-side too.
Perhaps related to the event in the test app that was replaced with onViewOpen instead of onFrontstage...?
Co-authored-by: Diego Pinate <diegopinatem@gmail.com>
diegopinate
previously approved these changes
Sep 16, 2025
diegopinate
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PropertyComparisonTable accepts selection as KeySet, which is part of the deprecated unified selection system. Selectables are replacing KeySet from @itwin/unified-selection package. PopertyComparisonTable should accept Selectables.
Updated all Itwin JS to 5.x.x and stopped using deprecated methods.
fixes: