Update mapLayers.json #1430
Open
Update mapLayers.json #1430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an entry for MapboxImagery to the localization JSON files.
zhang-zimin
requested review from
a team,
eringram and
mdastous-bentley
as code owners
Author
Localized WellKnownBaseMaps are missing Mapbox entries. |
aruniverse
approved these changes
Sep 11, 2025
Member
aruniverse
left a comment
aruniverse
left a comment
There was a problem hiding this comment.
lgtm; but missing rush change files
eringram
reviewed
Sep 12, 2025
| "satellite-layerRoadmap": "Google Maps: Aerial Imagery with labels", | ||
| "roadmap": "Google Maps: Streets" | ||
| }, | ||
| "MapBoxImagery": { |
Member
There was a problem hiding this comment.
Should this be "MapBoxImagery", or "MapboxImagery" with a lowercase "b"? I have been using the test viewer to try to reproduce the fix locally with your fork, but am still unable to see the correct localization with this change.
I suspect it should be lowercase because the format ID in MapLayerSettings.ts is "MapboxImagery". Do you have a screenshot of this change fixing the UI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an entry for MapboxImagery to the localization JSON files.