Accept window and document arguments in polyfill method#142
Open
james2406 wants to merge 1 commit intoiamdustan:masterfrom
Open
Accept window and document arguments in polyfill method#142james2406 wants to merge 1 commit intoiamdustan:masterfrom
james2406 wants to merge 1 commit intoiamdustan:masterfrom
Conversation
Owner
|
Would you call this with something like I assume it isn’t possible to load the polyfill on the iframe itself as well 🤔 |
Author
|
Yes, that would apply the polyfill to the iframe. In my case, I am using the react-frame-component library to render my react app in an iframe. I'm then using the frames context to apply the polyfill to that iframe: import Frame, { FrameContextConsumer } from 'react-frame-component'
import smoothscroll from 'smoothscroll-polyfill';
const MyComponent = (props, context) => (
<Frame>
<FrameContextConsumer>
{
// Callback is invoked with iframe's window and document instances
({ window, document }) => {
smoothscroll.polyfill(window, document);
// Render Children
}
}
</FrameContextConsumer>
</Frame>
);Tested on chrome, safari, firefox, ie11 and iOS |
Owner
|
This is only necessary because we don’t auto-polyfill on load, correct? If we did, then the solution would be to just load the script into the iframe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow the window and document context to be overridden, useful when targeting another document on the page (e.g. an iframe)