Fix for #150: check for documentElement instead of body#151
Open
dvdrhr wants to merge 1 commit intoiamdustan:masterfrom
Open
Fix for #150: check for documentElement instead of body#151dvdrhr wants to merge 1 commit intoiamdustan:masterfrom
dvdrhr wants to merge 1 commit intoiamdustan:masterfrom
Conversation
Collaborator
|
Thanks for the PR first of all. I think this one is missing a couple of edge cases for example when an element forces the window plus its scrollable container to scroll, d.body is referenced in other cases. I'd recommend running your local build in the repository page to test each case. I will try to take a further look to try to detect edge cases. But the change is pointing into the right direct and it does solve your reported case in the issue 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#150
works for me, tested in chrome, safari, edge, mobile chrome and mobile safari