Skip to content

Conversation

@ianpaschal
Copy link
Owner

@ianpaschal ianpaschal commented Jul 21, 2025

Summary by CodeRabbit

  • New Features

    • Introduced a responsive, interactive Dashboard with tabbed navigation for mobile and desktop layouts.
    • Added dashboard cards for Tournaments, Match Results, and Stats, each with dedicated components and styles.
    • Enabled viewing and filtering of tournaments by user and status, with new hooks and API endpoints.
    • Added detailed active tournament display, including opponent info, rankings, and check-in functionality.
  • Enhancements

    • Improved tournament and match result forms to support direct pairing selection and better state control.
    • Refined empty state handling across multiple components with a unified, reusable EmptyState component.
    • Updated route paths for match results to use /matches for improved clarity.
  • Style

    • Added and updated numerous SCSS modules for dashboard and card layouts, ensuring consistent and modern UI styling.
    • Introduced a new large text mixin for scalable typography.
  • Bug Fixes

    • Improved filtering and data fetching logic for tournaments and pairings, allowing more flexible round selection and user-specific queries.
  • Chores

    • Generalized and streamlined component and style naming for better reusability and maintainability.

@vercel
Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
combat-command ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 5:21am

@coderabbitai
Copy link

coderabbitai bot commented Jul 21, 2025

Walkthrough

This update introduces a comprehensive redesign of the dashboard and related components, adding new cards for tournaments, match results, and stats, along with supporting SCSS modules and utility files. Several backend query endpoints and argument schemas are expanded or added for enhanced tournament data retrieval. Multiple components are refactored for generalization and reusability, with corresponding updates to imports and exports.

Changes

Files/Paths Change Summary
convex/_model/tournamentPairings/queries/getActiveTournamentPairingsByUser.ts Query schema extended with optional round argument; logic updated to use provided or current round.
convex/_model/tournaments/index.ts Added exports for new/query argument schemas and user-based tournament queries.
convex/_model/tournaments/queries/getTournaments.ts Query now accepts optional startsAfter argument; filtering logic updated; argument schema added.
convex/_model/tournaments/queries/getTournamentsByUser.ts New query: retrieves tournaments for a user, with optional status filter and argument schema.
convex/_model/utils/createTestTournamentMatchResults.ts Insert logic updated to explicitly set tournamentId; comment added for future mutation use.
convex/tournaments.ts Added new queries for tournaments by status/user; updated existing query to use argument schema.
src/components/CheckInMatchDialog/CheckInMatchDialog.tsx Added optional tournamentPairingId prop, passed to nested form.
src/components/EmptyState/EmptyState.module.scss, src/components/EmptyState/EmptyState.tsx Generalized class/component names from "TournamentTabEmptyState" to "EmptyState".
src/components/EmptyState/index.ts Added export for EmptyState component.
src/components/FowV4MatchResultForm/FowV4MatchResultForm.tsx Added optional tournamentPairingId prop; disables select input if provided; state logic updated.
src/components/PageWrapper/PageWrapper.module.scss Adjusted padding and header height styles for layout refinement.
src/components/TournamentTimer/TournamentTimer.module.scss Removed border/shadow/corner mixins; standardized padding via CSS variable.
src/components/generic/Table/Table.module.scss Reduced minimum table cell width from 2.5rem to 1.5rem.
src/components/generic/Table/Table.types.ts ColumnDef.width type expanded to accept 'auto' in addition to numbers.
src/pages/DashboardPage/DashboardPage.module.scss, .ts(x) Dashboard rewritten: responsive layout, tabbed navigation, new cards for tournaments, matches, stats.
src/pages/DashboardPage/components/ActiveTournament/* New component, SCSS module, utilities, and index for displaying active tournament info.
src/pages/DashboardPage/components/Header/* New header component, SCSS module, and index for use in dashboard cards.
src/pages/DashboardPage/components/MatchResultsCard/* New card component, SCSS module, and index for displaying recent match results.
src/pages/DashboardPage/components/StatsCard/* New card component, SCSS module, and index for displaying stats (placeholder/empty state).
src/pages/DashboardPage/components/TournamentsCard/* New card component, SCSS module, utilities, and index for displaying tournaments and live info.
src/pages/DashboardPage/components/TournamentsList/* New list component, SCSS module, and index for displaying upcoming tournaments.
src/pages/TournamentDetailPage/components/TournamentDetailBanner/TournamentDetailBanner... Added border, shadow, and corner mixins to timer section; overflow hidden.
src/pages/TournamentDetailPage/components/TournamentMatchResultsCard/TournamentMatchRes... Swapped TournamentTabEmptyState for new EmptyState component.
src/pages/TournamentDetailPage/components/TournamentPairingsCard/TournamentPairingsCard... Table text styling simplified using new text.large mixin.
src/pages/TournamentDetailPage/components/TournamentPairingsCard/TournamentPairingsCard... Swapped TournamentTabEmptyState for new EmptyState component.
src/pages/TournamentDetailPage/components/TournamentRankingsCard/TournamentRankingsCard.tsx Swapped TournamentTabEmptyState for new EmptyState component.
src/pages/TournamentDetailPage/components/TournamentRosterCard/TournamentRosterCard.tsx Swapped TournamentTabEmptyState for new EmptyState component.
src/pages/TournamentDetailPage/components/TournamentTabEmptyState/index.ts Removed export for TournamentTabEmptyState.
src/services/tournaments.ts Added query hooks for tournaments by status and by user.
src/settings.ts Updated match results routes from /match-results to /matches.
src/style/_text.scss Added new large text mixin for consistent large text styling.

Estimated code review effort

3 (120 minutes)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 24c5dcf and 08ada6f.

⛔ Files ignored due to path filters (1)
  • convex/_generated/api.d.ts is excluded by !**/_generated/**
📒 Files selected for processing (47)
  • convex/_model/tournamentPairings/queries/getActiveTournamentPairingsByUser.ts (2 hunks)
  • convex/_model/tournaments/index.ts (1 hunks)
  • convex/_model/tournaments/queries/getTournaments.ts (1 hunks)
  • convex/_model/tournaments/queries/getTournamentsByUser.ts (1 hunks)
  • convex/_model/utils/createTestTournamentMatchResults.ts (1 hunks)
  • convex/tournaments.ts (1 hunks)
  • src/components/CheckInMatchDialog/CheckInMatchDialog.tsx (3 hunks)
  • src/components/EmptyState/EmptyState.module.scss (1 hunks)
  • src/components/EmptyState/EmptyState.tsx (1 hunks)
  • src/components/EmptyState/index.ts (1 hunks)
  • src/components/FowV4MatchResultForm/FowV4MatchResultForm.tsx (3 hunks)
  • src/components/PageWrapper/PageWrapper.module.scss (1 hunks)
  • src/components/TournamentTimer/TournamentTimer.module.scss (2 hunks)
  • src/components/generic/Table/Table.module.scss (1 hunks)
  • src/components/generic/Table/Table.types.ts (1 hunks)
  • src/pages/DashboardPage/DashboardPage.module.scss (1 hunks)
  • src/pages/DashboardPage/DashboardPage.tsx (1 hunks)
  • src/pages/DashboardPage/components/ActiveTournament/ActiveTournament.module.scss (1 hunks)
  • src/pages/DashboardPage/components/ActiveTournament/ActiveTournament.tsx (1 hunks)
  • src/pages/DashboardPage/components/ActiveTournament/ActiveTournament.utils.tsx (1 hunks)
  • src/pages/DashboardPage/components/ActiveTournament/index.ts (1 hunks)
  • src/pages/DashboardPage/components/Header/Header.module.scss (1 hunks)
  • src/pages/DashboardPage/components/Header/Header.tsx (1 hunks)
  • src/pages/DashboardPage/components/Header/index.ts (1 hunks)
  • src/pages/DashboardPage/components/MatchResultsCard/MatchResultsCard.module.scss (1 hunks)
  • src/pages/DashboardPage/components/MatchResultsCard/MatchResultsCard.tsx (1 hunks)
  • src/pages/DashboardPage/components/MatchResultsCard/index.ts (1 hunks)
  • src/pages/DashboardPage/components/StatsCard/StatsCard.module.scss (1 hunks)
  • src/pages/DashboardPage/components/StatsCard/StatsCard.tsx (1 hunks)
  • src/pages/DashboardPage/components/StatsCard/index.ts (1 hunks)
  • src/pages/DashboardPage/components/TournamentsCard/TournamentsCard.module.scss (1 hunks)
  • src/pages/DashboardPage/components/TournamentsCard/TournamentsCard.tsx (1 hunks)
  • src/pages/DashboardPage/components/TournamentsCard/TournamentsCard.utils.ts (1 hunks)
  • src/pages/DashboardPage/components/TournamentsCard/index.ts (1 hunks)
  • src/pages/DashboardPage/components/TournamentsList/TournamentsList.module.scss (1 hunks)
  • src/pages/DashboardPage/components/TournamentsList/TournamentsList.tsx (1 hunks)
  • src/pages/DashboardPage/components/TournamentsList/index.ts (1 hunks)
  • src/pages/TournamentDetailPage/components/TournamentDetailBanner/TournamentDetailBanner.module.scss (2 hunks)
  • src/pages/TournamentDetailPage/components/TournamentMatchResultsCard/TournamentMatchResultsCard.tsx (2 hunks)
  • src/pages/TournamentDetailPage/components/TournamentPairingsCard/TournamentPairingsCard.module.scss (1 hunks)
  • src/pages/TournamentDetailPage/components/TournamentPairingsCard/TournamentPairingsCard.tsx (2 hunks)
  • src/pages/TournamentDetailPage/components/TournamentRankingsCard/TournamentRankingsCard.tsx (2 hunks)
  • src/pages/TournamentDetailPage/components/TournamentRosterCard/TournamentRosterCard.tsx (2 hunks)
  • src/pages/TournamentDetailPage/components/TournamentTabEmptyState/index.ts (0 hunks)
  • src/services/tournaments.ts (1 hunks)
  • src/settings.ts (1 hunks)
  • src/style/_text.scss (1 hunks)
💤 Files with no reviewable changes (1)
  • src/pages/TournamentDetailPage/components/TournamentTabEmptyState/index.ts

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ianpaschal ianpaschal merged commit f91ef9c into develop Jul 21, 2025
4 checks passed
@ianpaschal ianpaschal deleted the feat-57-implement-basic-dashboard branch July 21, 2025 06:46
ianpaschal added a commit that referenced this pull request Jul 24, 2025
* Update update-project-status.yml

* Update updateProjectStatus.js

* fix: Toast text does not wrap (#87)

* fix: Sanitize sign in/sign up inputs (#91)

#86

* feat: #32 Auto generate avatars & refactor users (#90)

* feat: Improve <TournamentDetailPage/> default tab

* feat: Improve <TournamentCard/> styling

* Update mockData.ts

* feat: Improve <AccordionItem/> disabled state (#97)

#94

* feat: Hide completed pairings from match check-in (#96)

#95

* bug: Preserve <TournamentPairingsGrid/> internal state (#98)

#93

* feat: #101 Add player count to roster (#103)

* feat: Show full player names when tournaments require it

* feat: Add activePlayerCount to deep tournaments

* feat: Sort tournament competitors by name

* task: Clean-up .card mixin (#102)

#100

* feat: #99 Improve tournament competitor edit dialog (#104)

* feat: #106 Improve signIn error handling (#107)

* Update convex/_model/tournamentCompetitors/queries/getTournamentCompetitorsByTournament.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update convex/_model/users/_helpers/checkUserTournamentForcedName.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* feat: Hide players with 0 matches from rankings

* feat: #112 Add more mercenary team options (#113)

* feat: #110 Add manual table assignments (#111)

* fix: Ensure round 0 rankings can be included

* Refactor tournament actions (#114)

* refactor: Improve tournament actions

* chore: Clean-up Convex errors

* fix: Do not try to clean up current round timer on tournament end

* fix: Don't allow players to be removed from tournament

* chore: Update test tournament banner image

* Update TournamentCard.tsx

* fix: Ensure round 0 rankings can be included

* fix: Fix end tournament round context menu behavior

* chore: Improve mock match result creation

* feat: Allow matchResult.playedAt to be date string or number

* feat: #115 Hide match result battle plans (#116)

* feat: Set page title based on <PageWrapper/> title prop

* fix: Use <IdentityBadge/> to fix player name spacing on match results

* fix: Correctly include match results relevant to a tournament

* feat: #57 Implement basic dashboard (#119)

* fix: Remove double border on dashboard sections

* fix: Add key to dashboard tournaments

* feat: Improve <TournamentPairingRow/> styling

* fix: Remove extraneous error message

* fix: Improve <Form/> isDirty calculation

* fix: Render all competitors in <TournamentCompetitorForm/>

* fix: Also show empty state if rankings are empty

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants