ETC final touches

[ianpaschal]

Summary by CodeRabbit

• New Features

  • Added a "Submit Match Result" action in tournaments, allowing users to submit match results via a new dialog.
  • Introduced a "Match Result Create" dialog with a dedicated form for submitting match results.
  • Implemented incremental loading ("Load More") for match results on the Match Results page.
  • All match results are now displayed on the dashboard, not just the first five.

• Improvements

  • Match results queries and data fetching now support pagination for better performance and scalability.
  • Enhanced list rendering and styling for match results and related dialogs.

• Bug Fixes

  • Corrected key assignment in dashboard tab rendering to improve React list handling.

• Chores

  • Updated and refactored internal hooks and utilities to support new features and pagination.
  • Improved code structure by introducing index files and re-exports for easier imports.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
combat-command	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2025 7:35pm

[coderabbitai]

Walkthrough

This update introduces paginated loading for match results throughout the stack. It refactors backend queries and React hooks to support pagination, adds a paginated query utility, and updates UI components for incremental result loading. New dialogs and actions for submitting match results are integrated, along with related UI and style enhancements.

Changes

Files / Areas	Change Summary
convex/_model/fowV4/aggregateFowV4TournamentData.ts, convex/_model/fowV4/extractFowV4MatchResultBaseStats.ts, convex/_model/matchResults/_helpers/checkMatchResultBattlePlanVisibility.ts	Refactored data access patterns, updated function signatures, and simplified logic for tournament and match result handling.
convex/_model/matchResults/index.ts, convex/_model/matchResults/queries/getMatchResults.ts, convex/matchResults.ts	Added/updated exports and query argument validation; getMatchResults now supports pagination and returns paginated results.
convex/_model/tournaments/index.ts	Added SubmitMatchResult to the TournamentActionKey enum.
src/components/MatchResultCreateDialog/MatchResultCreateDialog.hooks.tsx, src/components/MatchResultCreateDialog/MatchResultCreateDialog.tsx, src/components/MatchResultCreateDialog/MatchResultCreateDialog.module.scss, src/components/MatchResultCreateDialog/index.ts	Introduced a match result creation dialog component, custom hook, and associated styles with re-exports.
src/components/TournamentActionsProvider/TournamentActionsProvider.hooks.tsx, src/components/TournamentActionsProvider/TournamentActionsProvider.tsx	Added "Submit Match Result" action and integrated the match result dialog into the provider component.
src/pages/DashboardPage/DashboardPage.tsx, src/pages/DashboardPage/components/MatchResultsCard/MatchResultsCard.tsx	Adjusted key assignment in tab rendering and removed result truncation; now all match results are displayed.
src/pages/MatchResultsPage/MatchResultsPage.module.scss, src/pages/MatchResultsPage/MatchResultsPage.tsx	Added "Load More" button and related styles for incremental match result loading in the match results page.
src/services/matchResults.ts, src/services/utils/createPaginatedQueryHook.ts, src/services/utils/index.ts	Switched to a paginated query hook for match results, introduced a generic paginated query utility, and exported it.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Complexity: Moderate. The changes span backend and frontend, introduce new utilities and UI components, and refactor data flows for pagination. The logic is mostly additive or refactoring, with no highly complex algorithms.
• Volume: Several files affected, but changes are focused and cohesive around pagination and dialog integration.
• Review time estimate: ~20 minutes for a thorough review of backend, utility, and UI changes.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between aa1de2f and 8f119c2.

📒 Files selected for processing (20)

• convex/_model/fowV4/aggregateFowV4TournamentData.ts (2 hunks)
• convex/_model/fowV4/extractFowV4MatchResultBaseStats.ts (1 hunks)
• convex/_model/matchResults/_helpers/checkMatchResultBattlePlanVisibility.ts (2 hunks)
• convex/_model/matchResults/index.ts (1 hunks)
• convex/_model/matchResults/queries/getMatchResults.ts (1 hunks)
• convex/_model/tournaments/index.ts (1 hunks)
• convex/matchResults.ts (1 hunks)
• src/components/MatchResultCreateDialog/MatchResultCreateDialog.hooks.tsx (1 hunks)
• src/components/MatchResultCreateDialog/MatchResultCreateDialog.module.scss (1 hunks)
• src/components/MatchResultCreateDialog/MatchResultCreateDialog.tsx (1 hunks)
• src/components/MatchResultCreateDialog/index.ts (1 hunks)
• src/components/TournamentActionsProvider/TournamentActionsProvider.hooks.tsx (3 hunks)
• src/components/TournamentActionsProvider/TournamentActionsProvider.tsx (2 hunks)
• src/pages/DashboardPage/DashboardPage.tsx (1 hunks)
• src/pages/DashboardPage/components/MatchResultsCard/MatchResultsCard.tsx (1 hunks)
• src/pages/MatchResultsPage/MatchResultsPage.module.scss (1 hunks)
• src/pages/MatchResultsPage/MatchResultsPage.tsx (2 hunks)
• src/services/matchResults.ts (1 hunks)
• src/services/utils/createPaginatedQueryHook.ts (1 hunks)
• src/services/utils/index.ts (1 hunks)

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.