Add option to disable first/last marker of polyline (#44)#45
Open
leiflinse-trivector wants to merge 1 commit intoibrierley:masterfrom
Open
Add option to disable first/last marker of polyline (#44)#45leiflinse-trivector wants to merge 1 commit intoibrierley:masterfrom
leiflinse-trivector wants to merge 1 commit intoibrierley:masterfrom
Conversation
ibrierley
reviewed
Apr 27, 2024
Owner
ibrierley
left a comment
ibrierley
left a comment
There was a problem hiding this comment.
I think this is almost ok. I think it would be better with a fixed initial icon though or it's not necessarily clear what's happening. Eg with a polyline, you click on a point, nothing happens unless you click elsewhere... I wonder if it would make more sense for the start/endMarker params to be something like fixedStartMarker (which is actually a marker rather than a bool?). If that is defined, then the marker for that is used (then you could have a red start/end icon, and green movable ones or something ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For task #44