feat: umd format will enable inlineDynamicImports

.changeset/chilled-pillows-joke.md

@@ -0,0 +1,5 @@
+---
+'@ice/pkg': minor
+---
+
+feat: umd format will enable inlineDynamicImports

packages/pkg/src/engine/shared/outputs.ts

@@ -77,11 +77,16 @@ export function getOutputs({
       if (minify) {
         options.plugins = [minifyPlugin(bundleTaskConfig.sourcemap, typeof minify === 'boolean' ? {} : minify.options)];
       }
+      options.inlineDynamicImports = format.module === 'umd';
     } else if (engine === 'rolldown') {
       const rolldownOuptut = options as RolldownOutputOptions;
       if (minify) {
         rolldownOuptut.minify = typeof minify === 'boolean' ? minify : minify.options;
       }
+      // rolldown can auto handle umd format to disable codeSplitting
+      // if (format.module === 'umd') {
+      //   rolldownOuptut.codeSplitting = false
+      // }
     }
 
     return options;

tests/integration/bundle-dep/__snapshots__/index.test.ts.snap

@@ -56,3 +56,71 @@ exports[`Run config default-venders > dist structure 1`] = `
   "name": "dist",
 }
 `;
+
+exports[`Run config dynamic-import > dist structure 1`] = `
+{
+  "files": [
+    {
+      "name": "dynamic-import.umd.es5.production.js",
+    },
+  ],
+  "name": "dist",
+}
+`;
+
+exports[`Run config dynamic-import-pkg > dist structure 1`] = `
+{
+  "files": [
+    {
+      "name": "dynamic-import.cjs.es5.production.js",
+    },
+    {
+      "name": "dynamic-import.esm.es5.production.js",
+    },
+    {
+      "name": "dynamic-import.umd.es5.production.js",
+    },
+    {
+      "name": "vendor.cjs.es5.production.js",
+    },
+    {
+      "name": "vendor.esm.es5.production.js",
+    },
+  ],
+  "name": "dist",
+}
+`;
+
+exports[`Run config dynamic-import-pkg-rolldown > dist structure 1`] = `
+{
+  "files": [
+    {
+      "name": "dynamic-import.cjs.es5.production.js",
+    },
+    {
+      "name": "dynamic-import.esm.es5.production.js",
+    },
+    {
+      "name": "dynamic-import.umd.es5.production.js",
+    },
+    {
+      "name": "vendor.cjs.es5.production.js",
+    },
+    {
+      "name": "vendor.esm.es5.production.js",
+    },
+  ],
+  "name": "dist",
+}
+`;
+
+exports[`Run config dynamic-import-rolldown > dist structure 1`] = `
+{
+  "files": [
+    {
+      "name": "dynamic-import.umd.es5.production.js",
+    },
+  ],
+  "name": "dist",
+}
+`;

tests/integration/bundle-dep/index.test.ts

@@ -46,6 +46,43 @@ const tests: ProjectTestUserConfig[] = [
       ],
     },
   },
+  // should inlineDynamicImport for umd
+  {
+    name: 'dynamic-import',
+    config: {
+      entry: './src/dynamic-import.ts',
+      bundle: {
+        // rollup has error when using umd and cjs in same instance
+        // https://github.com/rollup/rollup/issues/6296
+        formats: ['umd'],
+      },
+    },
+    engine: ['rollup', 'rolldown'],
+  },
+  {
+    name: 'dynamic-import-pkg',
+    config: {
+      entry: './src/dynamic-import.ts',
+      pkgs: [
+        {
+          module: 'esm',
+          target: 'es5',
+          bundle: true,
+        },
+        {
+          module: 'cjs',
+          target: 'es5',
+          bundle: true,
+        },
+        {
+          module: 'umd',
+          target: 'es5',
+          bundle: true,
+        },
+      ],
+    },
+    engine: ['rollup', 'rolldown'],
+  },
 ];
 
 runProjectTest(

tests/integration/bundle-dep/package.json

@@ -4,6 +4,7 @@
   "private": true,
   "dependencies": {
     "@ice/pkg": "workspace:*",
+    "@swc/helpers": "^0.5.15",
     "es-toolkit": "^1.32.0"
   }
 }

tests/integration/bundle-dep/src/dynamic-import.ts

@@ -0,0 +1,4 @@
+export async function load() {
+  const { merge } = await import('es-toolkit');
+  return merge;
+}