1.2.9 merge #2
Draft
1.2.9 merge #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`method_missing` does not swallow kwargs on ruby 3 anymore
In practice, every backend class that is used in a model is a subclass of one of the base classes. Configured backend classes have a model class and set of options, whereas the base backend classes do not. However, previously you could still call `options` or `model_class` on the base classes and you would get back a `nil`. This is confusing since those getter methods should never be called on the base backend classes. In this commit I'm restructuring the code such that: - getter methods raise on the base backend class - methods which do not make sense on the base backend class are moved to a module which is included into backend subclasses. I think this should avoid weird bugs and misunderstandings.
This code is not actually covered by tests, but Sequel::SQL::Expression does not have `args`, ComplexExpression does, so let's fix this.
fixes dirty tracking and creating empty translation hashes on read fixes shioyama#540
Fixes mobility to work if subclassing a subclass of a mobility-enabled class, and looks up mobility_backend_classes later in execution (upon being called) to be more flexible.
This feature was implemented in 1.2 but I had to read the PR to understand how to use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test 1.2.9 merge of code