Remove orphan instances for Text and UTCTime #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is about time (and it's more conservative than GHC2024).
It removes two orphan instances which were long-present inside api-tools
Contributor
|
Related to #69. This does seem sensible, but it looks like CI needs some attention (as there don't seem to be any runners picking up the jobs, and we should test with a more up to date version set). We should also check the downstream project testsuite with this, because it would not surprise me if some tests start failing under the more rigorous testing regime (cf. #70). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #84, I recalled this one, and it looks like a hopefully non controversial fix.