Open
Conversation
Kolezhniuk
approved these changes
Apr 18, 2024
Member
|
Hi @glamperd! |
Author
|
It was a ~100Gb file (uncompressed ptau with 2^28 points) and it was on Ubuntu. Still, it's possible that environment was a factor, e.g. nodejs version. I was on v18.18.0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #101
A 'Range Error: Too many promises' error is thrown when reading a large file from disk. This error prevents running commands such as 'snarkjs powersoftau prepare phase2' on large files. In such circumstances, the number of promises reaches a limit inherent to node.js.
It is possible to circumvent the error by customising the node.js installation to insert a larger limit. This PR takes the approach of wrapping the promises array in an extra layer of batched promises. Large files can then be read with a native installation of node.js.
I have tested this code by successfully reading chunks of 34gb of data, sufficient to process a 2^28 powers of tau file.