Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the Rollup build by switching Node builtin fs imports to the node:fs specifier and updating the generated CJS bundle accordingly.
Changes:
- Updated
src/fastfile.jsto importfsconstants fromnode:fs. - Updated the generated
build/main.cjsbundle to usenode:fsfor constants. - Updated
package-lock.jsonmetadata for several packages (adds"peer": trueflags).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/fastfile.js | Switches fs constants import to node:fs to influence bundling/builtin resolution. |
| build/main.cjs | Reflects the node:fs change in the built CJS output (adds an extra require + uses node_fs.constants). |
| package-lock.json | Lockfile metadata changes (peer flags) likely from npm lockfile regeneration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kolezhniuk
approved these changes
Feb 12, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates both the CI workflow and the way file system constants are imported and used in the codebase. The main goals are to modernize CI Node.js version handling and to standardize the import of file system constants for better compatibility and clarity.
CI/CD Workflow Improvements:
mainbranch and on pull requests, instead of all branches. (.github/workflows/ci.yml)lts/*andlts/-1for broader and more future-proof coverage, and theactions/setup-nodeaction is updated to v4. (.github/workflows/ci.yml)File System Constants Refactoring:
src/fastfile.js, file system constants are now imported directly from theconstantsmodule, rather than destructured fromfs.constants, improving clarity and compatibility. (src/fastfile.js)build/main.cjs, all uses of file system constants are updated to referenceconstants(e.g.,constants.O_TRUNC) instead of relying on destructured variables, and theconstantsmodule is explicitly required. (build/main.cjs) [1] [2] [3] [4] [5] [6] [7]