Skip to content

Fix rollup build#134

Merged
OBrezhniev merged 3 commits intomasterfrom
fix/rollup_build
Feb 12, 2026
Merged

Fix rollup build#134
OBrezhniev merged 3 commits intomasterfrom
fix/rollup_build

Conversation

@OBrezhniev
Copy link
Member

@OBrezhniev OBrezhniev commented Feb 11, 2026

This pull request updates both the CI workflow and the way file system constants are imported and used in the codebase. The main goals are to modernize CI Node.js version handling and to standardize the import of file system constants for better compatibility and clarity.

CI/CD Workflow Improvements:

  • The CI workflow now only runs on pushes to the main branch and on pull requests, instead of all branches. (.github/workflows/ci.yml)
  • Node.js versions in the CI matrix now use lts/* and lts/-1 for broader and more future-proof coverage, and the actions/setup-node action is updated to v4. (.github/workflows/ci.yml)

File System Constants Refactoring:

  • In src/fastfile.js, file system constants are now imported directly from the constants module, rather than destructured from fs.constants, improving clarity and compatibility. (src/fastfile.js)
  • In build/main.cjs, all uses of file system constants are updated to reference constants (e.g., constants.O_TRUNC) instead of relying on destructured variables, and the constants module is explicitly required. (build/main.cjs) [1] [2] [3] [4] [5] [6] [7]

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix the Rollup build by switching Node builtin fs imports to the node:fs specifier and updating the generated CJS bundle accordingly.

Changes:

  • Updated src/fastfile.js to import fs constants from node:fs.
  • Updated the generated build/main.cjs bundle to use node:fs for constants.
  • Updated package-lock.json metadata for several packages (adds "peer": true flags).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/fastfile.js Switches fs constants import to node:fs to influence bundling/builtin resolution.
build/main.cjs Reflects the node:fs change in the built CJS output (adds an extra require + uses node_fs.constants).
package-lock.json Lockfile metadata changes (peer flags) likely from npm lockfile regeneration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@OBrezhniev OBrezhniev merged commit 1a48ccb into master Feb 12, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants