Add max_running_containers limit for resource management#80
Open
Add max_running_containers limit for resource management#80
Conversation
When multiple repositories are in use, each can have containers running across different dev names. This change adds a configurable limit on the maximum number of containers that can be running simultaneously. When the limit is reached and a new task needs to run, the least recently used idle container is automatically stopped to make room. Containers that are actively processing tasks are never evicted. Configuration: - MAX_RUNNING_CONTAINERS: Set to limit (default: 0 = no limit) Closes #79
Add max_running_containers = 0 to the mock_config fixture to prevent TypeError when the eviction logic checks this config value during tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_RUNNING_CONTAINERSconfiguration option to limit the number of containers running across all reposThis addresses the resource management concern when working with multiple repositories - each repo can have containers running across different dev names, and this provides a way to cap total resource usage.
Test plan
MAX_RUNNING_CONTAINERS=2to verify eviction behaviorCloses #79