Reproducing the Crash When Choosing eID for Identification#23
Open
La-Volpe wants to merge 1 commit intoidnow:masterfrom
Open
Reproducing the Crash When Choosing eID for Identification#23La-Volpe wants to merge 1 commit intoidnow:masterfrom
La-Volpe wants to merge 1 commit intoidnow:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
The crash occurs when selecting eID as the method for identification due to a deprecated API in the
org.jetbrains.kotlinx:kotlinx-coroutines-corepackage used by theidnow-android-eid-sdk.Root Cause:
The
de.authada.library, which is used by theidnow-android-eid-sdk, relies on an older version (1.3.4) of theorg.jetbrains.kotlinx:kotlinx-coroutines-corelibrary. A method within this version has since been deprecated, leading to the crash, as discussed in this pull request.Possible Solution:
Upon reviewing the dependency tree of the idnow-android-eid-sdk, it appears that more recent versions of the de.authada.library exist. The latest version is 4.23.0, as found here (requires authentication for access).
To address this issue, the version of de.authada.library used in the idnow-android-eid-sdk should be updated. For instance, if the current implementation looks like this:
It should be updated to:
This update is likely to resolve the issue or at least help mitigate it on the IDNow side.