Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
would test about the 0.1 case, since i haven't precisely test this one than the optimal (39/5600) one. would look into it, but i haven't received feedbacks leading to wrong results because of good/great, so i assume it should be somewhere working. this code definitely needs lots of rework to meet the quality standards, which ts could be a good entrypoint. would check this carefully when i have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides refactoring to split out the
ruleCheck(and TS, oop! my hands slipped there),this has an example of testing the collected feedback against a known 100% setup.
Since a correct rule should not break when compared to a perfect bias.
One feedback comes up bad currently, you can see this with:
yarn yarn test --watchSuggesting (assuming this feedback is correct) the good breakpoint might be slightly off.
I understand this isn't exactly a "minimal" PR.
So feel free to pick and choose as you see fit 😄