Open
Conversation
added 3 commits
June 17, 2024 04:36
- Implementation requires PIL library and external fonts (in most cases they are not present in OS by default) - Quotation placed in the center on white semitransparent rectangle, shape of rectangle depends on shape of image (flex container) - Font size automatically calculated depend on citation length - If citation is too long and calculated font size lower than certain value, exception raises -> can retry and get another citation - Generated image firstly saved to S3 in order to receive link to image be sent to teams Other changes: - Changed big size threshold in pre-commit large-files hook to 600KB from 500KB, because of font file (~540KB)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality to combine image and quotation
Other changes: