Create Room DB to use as merged data source#244
Draft
Iannnr wants to merge 3 commits intoimashnake0:mainfrom
Draft
Create Room DB to use as merged data source#244Iannnr wants to merge 3 commits intoimashnake0:mainfrom
Iannnr wants to merge 3 commits intoimashnake0:mainfrom
Conversation
Iannnr
commented
Jan 11, 2025
| } | ||
|
|
||
| configurations.implementation { | ||
| exclude(group = "com.intellij", module = "annotations") |
Collaborator
Author
There was a problem hiding this comment.
Room introduces duplicate annotation classes as something else, couldn't figure out what else, so just exclude in the model that introduced room :)
Iannnr
commented
Jan 11, 2025
|
|
||
| dependencies { | ||
| implementation(projects.api.anilist) | ||
| implementation(projects.api.mal) |
Collaborator
Author
There was a problem hiding this comment.
will remove this from :app after this repository does everything it needs to
Iannnr
commented
Jan 11, 2025
Comment on lines
+41
to
+42
| implementation(libs.hilt.android) | ||
| ksp(libs.hilt.android.compiler) |
Collaborator
Author
There was a problem hiding this comment.
these should probably become a convention plugin at this point
Iannnr
commented
Jan 11, 2025
| klass = SearchDatabase::class.java, | ||
| name = "search" | ||
| ) | ||
| .fallbackToDestructiveMigration() |
Collaborator
Author
There was a problem hiding this comment.
I ain't dealing with migrations with this project, that's too much effort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.Summary of changes:
Tested changes:
No functional code just yet, will replace SearchViewModel when more is hooked up