This repository was archived by the owner on Jan 4, 2023. It is now read-only.
Make extension (syntax highlighting for now) work in vscode web#112
Open
haikyuu wants to merge 2 commits intoimba:masterfrom
Open
Make extension (syntax highlighting for now) work in vscode web#112haikyuu wants to merge 2 commits intoimba:masterfrom
haikyuu wants to merge 2 commits intoimba:masterfrom
Conversation
haikyuu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #111
I have introduced webpack as a bundler (only) because it's indicated in the official docs. So that was the easiest way of doing it. Basically what it does is the following:
.jsbuilt file as an inputnoopfallback fornode-ipcWe could quite easily do the same with esbuild as I have built a couple of plugins for it before. But I'd wait until we expose esbuild config from imba.
I tested in Webkit browser locally and it looks like this
