This repository was archived by the owner on Jan 4, 2023. It is now read-only.
Open
Conversation
The `vscode.d.ts` file is not installed by the `postinstall` script of the `vscode` package anymore. It is now contained in `@types/vscode` on NPM. See https://code.visualstudio.com/updates/v1_36#_splitting-vscode-package-into-typesvscode-and-vscodetest
The `imba build` command referenced in the `build` script does not work. What actually needs to be built seem to be the `client/dist/src/index.js` and `server/dist/src/index.js` files. This change builds these files explicitly.
The compiled javascript uses the `??` and `?.` operators which are not compatible with the Node version that VS Code bundles. To avoid this, the compiled javascript is postprocessed with Babel to replace these operators by expressions that are supported by Node v12.18.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiled javascript uses the
??and?.operators which are notcompatible with the Node version that VS Code bundles. To avoid this,
the compiled javascript is postprocessed with Babel to replace these
operators by expressions that are supported by Node v12.18.3.
Fixes: #86
Note
Since the build process does not work on my machine, this PR is
dependent on #87, so it includes the commits from that PR at this point.
I created a separate PR since the changes from #87 should be considered
independently of the problem that this PR is meant to address.