Additional refactoring of XML_ParserStruct #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along with converting the backing storage, this commit also changes some pointers into the buffer into indices: m_bufferPtr: *const c_char -> m_bufferStart: usize m_bufferEnd: *mut c_char -> m_bufferEnd: usize m_positionPtr: *const c_char -> m_positionIdx: usize There are still more pointers that need to be converted as part of this change, but this is a minimal working set of changes.
thedataking
changed the title
thedataking
force-pushed
the
refactor/parser_buffer
branch
from
432051f to
480ed74
Compare
ahomescu
force-pushed
the
refactor/parser_buffer
branch
from
a08c805 to
825deb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is based off PR #34. The intent is to perform additional safety enhancements on this branch while #34 is waiting for review.