Update build_consensus_reference.py to fix Issue #20#21
Open
JTumulty wants to merge 1 commit intoimmunogenomics:mainfrom
Open
Update build_consensus_reference.py to fix Issue #20#21JTumulty wants to merge 1 commit intoimmunogenomics:mainfrom
JTumulty wants to merge 1 commit intoimmunogenomics:mainfrom
Conversation
Removed column name designation from pd.DataFrame.from_dict() call in lines 300-301
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR fixes the issue where an error is raised when the maximum size of clusters generated when running cluster_cnmf_results is less than the total number of datasets/paths passed to the BuildConsensusReference class.
Changes: Removed column name designation, "columns=[...]", from pd.DataFrame.from_dict() call in lines 300-301. This makes it so that the number of columns is just set by the maximum cluster size. These column names are never referenced again and the output of this function is not returned directly by the function so this change does not have any downstream effect.
Related Issue: Fixes #20