Update build_consensus_reference.py to prevent the AssertionError#7
Open
noranekonobokkusu wants to merge 1 commit intoimmunogenomics:mainfrom
Open
Update build_consensus_reference.py to prevent the AssertionError#7noranekonobokkusu wants to merge 1 commit intoimmunogenomics:mainfrom
noranekonobokkusu wants to merge 1 commit intoimmunogenomics:mainfrom
Conversation
The update prevents the AssertionError which is triggered when the largest identified consensus cluster is smaller than the original number of cNMF runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the largest identified cluster in
clus_dict_allis smaller than the total number of individual cNMF results (self.num_results),pd.DataFrame.from_dictcauses the assertion error, e.g.Traceback (most recent call last): File “/home/unix/safina/.conda/envs/cnmf/lib/python3.10/site-packages/pandas/core/internals/construction.py”, line 939, in _finalize_columns_and_data columns = _validate_or_indexify_columns(contents, columns) File “/home/unix/safina/.conda/envs/cnmf/lib/python3.10/site-packages/pandas/core/internals/construction.py”, line 986, in _validate_or_indexify_columns raise AssertionError( AssertionError: 6 columns passed, passed data had 4 columnswhich occurs because the largest identified consensus program consists of four individual programs from a total of six independent cNMF runs. Replacing
self.num_resultswith the size of the largest cluster solves the issue.